From: Claudio Cambra <claudio.cambra@nextcloud.com>
Date: Wed, 26 Mar 2025 12:21:30 +0000 (+0100)
Subject: gui/macOS: Avoid leaking objc objects added to arrays and dicts
X-Git-Tag: archive/raspbian/3.16.7-1_deb13u1+rpi1~1^2~12^2^2~62^2~13
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=548524dd09b3017c69216961972ef83c1977536c;p=nextcloud-desktop.git

gui/macOS: Avoid leaking objc objects added to arrays and dicts

The array/dict will retain them

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
---

diff --git a/src/gui/macOS/fileproviderxpc_mac_utils.mm b/src/gui/macOS/fileproviderxpc_mac_utils.mm
index eb385d1c4..fe33492ad 100644
--- a/src/gui/macOS/fileproviderxpc_mac_utils.mm
+++ b/src/gui/macOS/fileproviderxpc_mac_utils.mm
@@ -78,7 +78,6 @@ NSArray<NSDictionary<NSFileProviderServiceName, NSFileProviderService *> *> *get
                 } else if (service == nil) {
                     qCWarning(lcFileProviderXPCUtils) << "Service is nil";
                 } else {
-                    [service retain];
                     [fpServices addObject:@{service.name: service}];
                 }
                 dispatch_group_leave(group);
@@ -191,7 +190,6 @@ NSArray<NSXPCConnection *> *connectToFileProviderServices(NSArray<NSDictionary<N
                     return;
                 }
 
-                [connection retain];
                 [connections addObject:connection];
                 dispatch_group_leave(group);
             }];